Merge lp://staging/~vthompson/dropping-letters/fix-1366586-dropping-letters into lp://staging/dropping-letters
Proposed by
Victor Thompson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Alan Pope 🍺🐧🐱 🦄 | ||||
| Approved revision: | 60 | ||||
| Merged at revision: | 61 | ||||
| Proposed branch: | lp://staging/~vthompson/dropping-letters/fix-1366586-dropping-letters | ||||
| Merge into: | lp://staging/dropping-letters | ||||
| Diff against target: |
35 lines (+4/-0) 1 file modified
dropping-letters.qml (+4/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~vthompson/dropping-letters/fix-1366586-dropping-letters | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Nekhelesh Ramananthan (community) | Approve | ||
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Categorize Audio type
Description of the change
Dropping letters does not currently play audio (see lp:1368998) but once that is fixed, the audio category of the sound effects will need to be set.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Alan Pope 🍺🐧🐱 🦄 (popey) wrote | # |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:60
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
deb: http://
Click here to trigger a rebuild:
http://