YouTube WebApp

Merge lp://staging/~vrruiz/unity-webapps-youtube/const-to-var into lp://staging/unity-webapps-youtube

const-to-var
Merge into trunk

Proposed by Víctor R. Ruiz on 2013-06-11

Status:	Merged
Approved by:	Robert Bruce Park on 2013-06-12
Approved revision:	48
Merged at revision:	47
Proposed branch:	lp://staging/~vrruiz/unity-webapps-youtube/const-to-var
Merge into:	lp://staging/unity-webapps-youtube
Diff against target:	41 lines (+7/-5) 1 file modified YouTube.user.js (+7/-5)
To merge this branch:	bzr merge lp://staging/~vrruiz/unity-webapps-youtube/const-to-var
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alexandre Abreu (community)		2013-06-11	Approve on 2013-06-12
PS Jenkins bot (community)	continuous-integration		Approve on 2013-06-12
Review via email: mp+168753@code.staging.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-06-11:

FAILED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/unity-webapps-youtube-ci/1/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-youtube-saucy-amd64-ci/1/console
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-youtube-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-youtube-ci/1/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~vrruiz/unity-webapps-youtube/const-to-var updated on 2013-06-12

48. By Víctor R. Ruiz on 2013-06-12

Fix this bugs in style_checker:

YouTube.user.js:28->Expected ';' and instead saw 'function'.
YouTube.user.js:34->Expected a conditional expression and instead saw an assignment.
YouTube.user.js:35->Expected 'urlParams' at column 9, not column 8.
YouTube.user.js:75->['v'] is better written in dot notation.