YahooNews WebApp

Reviewer	Review Type	Date Requested	Status
Alexandre Abreu (community)		2013-07-31	Needs Fixing on 2013-08-01
PS Jenkins bot (community)	continuous-integration		Approve on 2013-07-31
Review via email: mp+177864@code.staging.launchpad.net

Commit message

Fix integration.

Description of the change

Fix integration.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-07-31:

FAILED: Continuous integration, rev:54
http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-ci/5/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-amd64-ci/5/console
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-yahoonews-ci/5/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~vrruiz/unity-webapps-yahoonews/fix-1188591 updated on 2013-07-31

55. By Víctor R. Ruiz on 2013-07-31: Fix YahooNews.user.js:62->'res' is already defined

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-07-31:

FAILED: Continuous integration, rev:55
http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-ci/6/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-amd64-ci/6/console
FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-armhf-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-yahoonews-ci/6/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~vrruiz/unity-webapps-yahoonews/fix-1188591 updated on 2013-07-31

56. By Víctor R. Ruiz on 2013-07-31: jslint fixes in YahooNews.test.js

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-07-31:

PASSED: Continuous integration, rev:56
http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-ci/7/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-amd64-ci/7
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-armhf-ci/7

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-yahoonews-ci/7/rebuild

review: Approve (continuous-integration)

Revision history for this message

Robert Bruce Park (robru) wrote on 2013-07-31:

Will this need to be SRU'd?

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2013-07-31:

> Will this need to be SRU'd?

yes :)

Revision history for this message

Robert Bruce Park (robru) wrote on 2013-08-01:

Ok. I'm at GUADEC right now but I'll try to get to this soon.

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2013-08-01:

as usual w/ the yahoo stuff, I don't think that news are dynamically pulled & updated, so it'll be as you browser which renders the setInterval useless ..

review: Needs Fixing

Revision history for this message

Robert Bruce Park (robru) wrote on 2013-11-01:

Whatever happened to this? Did it get fixed? Should I land/release/SRU this?

Revision history for this message

Víctor R. Ruiz (vrruiz) wrote on 2013-11-15:

Alex: In http://news.yahoo.com/ The headlines for "All News", "Yahoo Originals", and related tabs are loaded dinamically, that's why I used the timer.

Unmerged revisions

56. By Víctor R. Ruiz on 2013-07-31: jslint fixes in YahooNews.test.js
55. By Víctor R. Ruiz on 2013-07-31: Fix YahooNews.user.js:62->'res' is already defined
54. By Víctor R. Ruiz on 2013-07-31: Fix Yahoo News integration. Test fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Víctor R. Ruiz

WebApps