Merge lp://staging/~vrruiz/coverage-tutorial/have-gcov into lp://staging/coverage-tutorial

Proposed by Víctor R. Ruiz
Status: Merged
Approved by: Allan LeSage
Approved revision: 6
Merged at revision: 3
Proposed branch: lp://staging/~vrruiz/coverage-tutorial/have-gcov
Merge into: lp://staging/coverage-tutorial
Diff against target: 82 lines (+21/-18)
2 files modified
Makefile.am.coverage (+11/-11)
gcov.m4 (+10/-7)
To merge this branch: bzr merge lp://staging/~vrruiz/coverage-tutorial/have-gcov
Reviewer Review Type Date Requested Status
Allan LeSage Approve
Review via email: mp+119995@code.staging.launchpad.net
To post a comment you must log in.
4. By Víctor R. Ruiz

Oops. Fix flag names.

5. By Víctor R. Ruiz

* Substitute coverage flags with --coverage
* Fix use_gcov=yes
* Only call to shtool if installed

6. By Víctor R. Ruiz

Use top indentation for Makefile.am.coverage (makes vim happy)

Revision history for this message
Allan LeSage (allanlesage) wrote :

Approve, thanks for your diligence; need to update with a couple of other items which have come up since publication.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: