Merge lp://staging/~vorlon/ubuntu/precise/cups/udevtrigger-optimization into lp://staging/ubuntu/precise/cups
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~vorlon/ubuntu/precise/cups/udevtrigger-optimization |
| Merge into: | lp://staging/ubuntu/precise/cups |
| Diff against target: |
45 lines (+13/-3) 3 files modified
debian/changelog (+10/-0) debian/control (+2/-1) debian/local/cups.upstart (+1/-2) |
| To merge this branch: | bzr merge lp://staging/~vorlon/ubuntu/precise/cups/udevtrigger-optimization |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Pitt | Approve | ||
| Till Kamppeter | Pending | ||
|
Review via email:
|
|||
Description of the change
Hi guys, could I ask you to review this proposed change to the cups upstart
job before I land it, and check my reasoning (given in the changelog)?
I'm reasonably sure that we don't need to wait for udevtrigger, but would
like a second opinion before I push such a change at this point in the
cycle.
The reason I'm looking at this is because the udevtrigger upstart job has
regressed a bit this cycle performance-wise, now using a script where before
it was a simple exec; to fix that while making cups container-
need to either drop the reference to udevtrigger in cups, or add an 'or
container'.
Unmerged revisions
- 99. By Steve Langasek
-
releasing version 1.5.2-9ubuntu1
- 98. By Steve Langasek
-
run update-maintainer
- 97. By Steve Langasek
-
Don't wait on udevtrigger before starting cups; the only reason this
is here is to let '/lib/udev/udev-configure- printer enumerate' work, but
if cups does start before we've cold-plugged everything, the udev rule
will call '/lib/udev/udev-configure- printer add' for each device it
discovers anyway, so this is redundant.
LGTM, thanks! I committed that to the Debian packaging bzr, so we can sync the next time again. But feel free to upload this in the meantime.