Merge into ubuntu : lp.1069019 : Code : the python apt bindings

Merge lp://staging/~vorlon/python-apt/lp.1069019 into lp://staging/~ubuntu-core-dev/python-apt/ubuntu

Proposed by Steve Langasek
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp://staging/~vorlon/python-apt/lp.1069019
Merge into: lp://staging/~ubuntu-core-dev/python-apt/ubuntu
Diff against target: 102 lines (+23/-16)
2 files modified
To merge this branch: bzr merge lp://staging/~vorlon/python-apt/lp.1069019
Reviewer Review Type Date Requested Status
Brian Murray Approve
Barry Warsaw Pending
Review via email: mp+166148@code.staging.launchpad.net

Description of the change

Possible fix for bug #1069019, using io.open() and enforcing use of Unicode
internally for the handling of the sources.list entries. Does this look
sane?

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

I think I still prefer using codecs.open() instead of io.open(), but mostly because the former is more common usage. It probably ultimately doesn't matter, and when Python 2 is dropped, either module prefix can be dropped (but neither hurt in either case).

Any chance you can come up with a test case for this bug?

Revision history for this message
Brian Murray (brian-murray) wrote :

I tried recreating the bug by creating a sources.list entry with unicode in the comment (e.g. # disabled‽). Using the version of python-apt in saucy I was unable to disable this line or actually any other line in sources.list.

I then built an update version of the saucy package using Steve's patch in this branch and I was still not able to disable any line in my sources.list file. So I don't think this patch is sufficient.

Revision history for this message
Brian Murray (brian-murray) wrote :

I tested this again following the steps in the above comment, but this time I rebooted after installing python-apt, python3-apt and python-apt-common. After the reboot I am then able to enable and disable sources in software-properties.

Revision history for this message
Brian Murray (brian-murray) wrote :

I don't think we should keep holding out for a test case, especially given bug 1278280 regarding the release-upgrader (which includes sourceslist.py from python-apt) crashing. With the errors associated with that bug we should have positive confirmation that fix is working rather quickly.

I'll go ahead and take care of merging and uploading this.

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded this to trusty, but the python-apt branch is out of date so I'm not sure what to do with the mp.

Revision history for this message
Steve Langasek (vorlon) wrote :

It looks like in the time since this MP was raised, the python-apt upstream branch moved from Launchpad to git.debian.org, and since then the package was in sync with Debian. So let's close this out as "merged" and not worry about the ~ubuntu-core-dev branch. (Ideally we would not list Vcs-Git for this package as pointing to debian since there's no Ubuntu branch there, but that's secondary.)

Preview Diff

Failed to fetch available diffs.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: