Merge lp://staging/~voldyman/switchboard-plug-default-applications/rework into lp://staging/switchboard-plug-default-applications
Proposed by
Akshay Shekher
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~voldyman/switchboard-plug-default-applications/rework |
| Merge into: | lp://staging/switchboard-plug-default-applications |
| Diff against target: |
313 lines (+156/-77) 5 files modified
LICENSE (+1/-1) src/CMakeLists.txt (+3/-2) src/Utils.vala (+1/-1) src/Worker.vala (+84/-0) src/default-plug.vala (+67/-73) |
| To merge this branch: | bzr merge lp://staging/~voldyman/switchboard-plug-default-applications/rework |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Julián Unrrein (community) | code style | Needs Fixing | |
|
Review via email:
|
|||
Description of the change
the new branch updated the license year to 2013 and
switches form creating new threads to using a thread pool, which forces reuse of threads (making new threads is expensive)
To post a comment you must log in.
Revision history for this message
| Julián Unrrein (junrrein) wrote | # |
review:
Needs Fixing
(code style)
Unmerged revisions
- 65. By Akshay Shekher
-
Updated License year & Switched to thread pool instead of making new threads for each change.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Diff line 125, 128: Insert a space before the opening parenthesis.
Diff line 114: Insert a colon inside the warning, after "ocurred".
Diff line 128: Would it be better to use "message" or "warning"?