Switchboard About Plug

Merge lp://staging/~voldyman/switchboard-plug-about/reset-settings into lp://staging/~elementary-apps/switchboard-plug-about/trunk

  1. reset-settings
  2. Merge into trunk
Proposed by Akshay Shekher
Status: Merged
Approved by: Danielle Foré
Approved revision: 301
Merged at revision: 296
Proposed branch: lp://staging/~voldyman/switchboard-plug-about/reset-settings
Merge into: lp://staging/~elementary-apps/switchboard-plug-about/trunk
Diff against target: 242 lines (+133/-17)
1 file modified
src/Plug.vala (+133/-17)
To merge this branch: bzr merge lp://staging/~voldyman/switchboard-plug-about/reset-settings
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Danielle Foré Needs Fixing
Cameron Norman (community) Needs Fixing
Review via email: mp+256993@code.staging.launchpad.net

Commit message

Adds the ability to reset dconf keys org.gnome.desktop and org.pantheon.desktop

Description of the change

Adds the ability to reset dconf keys org.gnome.desktop and org.pantheon.desktop

To post a comment you must log in.
Revision history for this message
Cameron Norman (cameronnemo) wrote :

Some of the style fixes, specifically the closure bits, seem a bit off. Also see inline comments about the wording of the warning message.

review: Needs Fixing
lp://staging/~voldyman/switchboard-plug-about/reset-settings updated
298. By Akshay Shekher

Fixed indentations and comments

299. By Akshay Shekher

Improved the warning dialog

Revision history for this message
Danielle Foré (danrabbit) wrote :

* "Restore to default settings" -> "Restore Default Settings" and remove destructive action class

To fix dialog margins and padding:

    layout.set_column_spacing (12);
    layout.set_margin_right (6);
    layout.set_margin_bottom (18);
    layout.set_margin_left (6);

    dialog.border_width = 6;

review: Needs Fixing
lp://staging/~voldyman/switchboard-plug-about/reset-settings updated
300. By Akshay Shekher

Updated dialog box appearance

Revision history for this message
Cody Garver (codygarver) wrote :

Restore Default Dettings

review: Needs Fixing
lp://staging/~voldyman/switchboard-plug-about/reset-settings updated
301. By Akshay Shekher

Fixed typo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: