Merge lp://staging/~voldyman/scratch/fixes-1198495 into lp://staging/~elementary-apps/scratch/scratch
Proposed by
Akshay Shekher
Status: | Merged |
---|---|
Approved by: | Cody Garver |
Approved revision: | 1304 |
Merged at revision: | 1318 |
Proposed branch: | lp://staging/~voldyman/scratch/fixes-1198495 |
Merge into: | lp://staging/~elementary-apps/scratch/scratch |
Diff against target: |
109 lines (+56/-9) 1 file modified
src/Services/Document.vala (+56/-9) |
To merge this branch: | bzr merge lp://staging/~voldyman/scratch/fixes-1198495 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Approve | ||
Mario Guerriero (community) | Needs Fixing | ||
Sergey "Shnatsel" Davidoff (community) | Needs Fixing | ||
Review via email: mp+220901@code.staging.launchpad.net |
Commit message
Detect if file has been unmounted and offer to save it locally (fixes bug #1198495)
Description of the change
Fixed bug 1198495.
Whenever the file is changed, scratch will figure out the mount location and if it finds one it adds a callback to set mounted = false when the location is unmounted.
check_file_status function check the mounted variable to show the user alternatives when the file location is umounted
To post a comment you must log in.
We still have the no-autosave codepath in Scratch, so I believe we should handle this differently depending on whether the file was saved before unmounting or not. In particular, I'd like the regular "Save changes?" dialog should appear if the changes were not written to disk, otherwise closing Scratch results in silent data loss, which should never happen.
Also, "Save As" should be "Save As…"
Otherwise, looks good! Thanks!