Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://staging/~vlad-lesin/percona-server/5.5-bug-1354988 into lp://staging/percona-server/5.5

5.5-bug-1354988
Merge into 5.5

Proposed by Vlad Lesin on 2015-01-13

Status:

Merged

Approved by:

Laurynas Biveinis on 2015-02-13

Approved revision:

no longer in the source branch.

Merged at revision:

733

Proposed branch:

lp://staging/~vlad-lesin/percona-server/5.5-bug-1354988

Merge into:

lp://staging/percona-server/5.5

Diff against target:

255 lines (+125/-3)

5 files modified

mysql-test/r/grant.result (+13/-0)
mysql-test/r/grant_cache_no_prot.result (+2/-0)
mysql-test/r/percona_bug1354988.result (+50/-0)
mysql-test/t/percona_bug1354988.test (+53/-0)
sql/sql_acl.cc (+7/-3)

To merge this branch:

bzr merge lp://staging/~vlad-lesin/percona-server/5.5-bug-1354988

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Laurynas Biveinis (community)		2015-01-13	Approve on 2015-02-13
Review via email: mp+246277@code.staging.launchpad.net

Description of the change

Bug #1354988 fix.

Use compare_hostname() function instead of my_strcasecmp() in mysql_show_grants().

Revision history for this message

Vlad Lesin (vlad-lesin) wrote on 2015-01-13:

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/1080/

Revision history for this message

Laurynas Biveinis (laurynas-biveinis) wrote on 2015-01-13:

    - Grepping mysql_show_grants call tree for my_strcasecmp shows
      that the issue is fixed for database-level grants but should
      continue to exist for table, column and routine-level
      grants. This becomes quite unorthogonal, can you check this,
      expand the testcase, and fix this too?

- Once the patch is reviewed, please make a patch against MySQL
and submit by OCA to upstream 53645.

review: Needs Fixing

Revision history for this message

Vlad Lesin (vlad-lesin) wrote on 2015-02-12:

> - Grepping mysql_show_grants call tree for my_strcasecmp shows
> that the issue is fixed for database-level grants but should
> continue to exist for table, column and routine-level
> grants. This becomes quite unorthogonal, can you check this,
> expand the testcase, and fix this too?
Yes, you are right, I fixed mysql_show_grants() and it's subroutines so host name is compared with wildcards for all grant levels.

> - Once the patch is reviewed, please make a patch against MySQL
> and submit by OCA to upstream 53645.
Will do after code review.

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/1090/