OpenStack Compute (nova)

Merge lp://staging/~vishvananda/nova/lp803524 into lp://staging/~hudson-openstack/nova/trunk

  1. lp803524
  2. Merge into trunk
Proposed by Vish Ishaya
Status: Merged
Approved by: Brian Lamar
Approved revision: 1224
Merged at revision: 1257
Proposed branch: lp://staging/~vishvananda/nova/lp803524
Merge into: lp://staging/~hudson-openstack/nova/trunk
Diff against target: 70 lines (+27/-4)
2 files modified
nova/api/openstack/images.py (+14/-4)
nova/tests/api/openstack/test_images.py (+13/-0)
To merge this branch: bzr merge lp://staging/~vishvananda/nova/lp803524
Reviewer Review Type Date Requested Status
Brian Lamar (community) Approve
Christopher MacGown (community) Approve
Brian Waldon (community) Approve
Review via email: mp+66351@code.staging.launchpad.net

Description of the change

Allows for ports in serverRef in image create through the openstack api.

To post a comment you must log in.
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Thanks for the fix, Vish. Can you remove (or expand) line 17?

review: Needs Fixing
Revision history for this message
Brian Lamar (blamar) wrote :

Would it make more sense to use a library geared to this, like urlparse?

review: Needs Information
Revision history for this message
Vish Ishaya (vishvananda) wrote :

updated to use urlparse

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Vish, looks like line 38 could be left in by accident. Please correct me if I'm wrong.

Revision history for this message
Vish Ishaya (vishvananda) wrote :

correct. Fixed

lp://staging/~vishvananda/nova/lp803524 updated
1224. By Vish Ishaya

remove logging statement

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Looks good.

review: Approve
Revision history for this message
Christopher MacGown (0x44) wrote :

This looks good.

review: Approve
Revision history for this message
Brian Lamar (blamar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.