OpenStack Compute (nova)

Merge lp://staging/~vishvananda/nova/lp767849 into lp://staging/~hudson-openstack/nova/trunk

lp767849
Merge into trunk

Proposed by Vish Ishaya on 2011-04-20

Status:

Merged

Approved by:

Jay Pipes on 2011-04-21

Approved revision:

1008

Merged at revision:

1010

Proposed branch:

lp://staging/~vishvananda/nova/lp767849

Merge into:

lp://staging/~hudson-openstack/nova/trunk

Diff against target:

12 lines (+1/-1)

1 file modified

nova/api/ec2/cloud.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~vishvananda/nova/lp767849

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Jay Pipes (community)		Approve on 2011-04-21
termie (community)	2011-04-20	Approve on 2011-04-20
Review via email: mp+58597@code.staging.launchpad.net

Description of the change

Makes metadata correctly display kernel-id and ramdisk-id.

References from the Database don't support "in".

Revision history for this message

termie (termie) wrote on 2011-04-20:

I'd almost argue that we should support 'in' (and/or just return the dict version instead). Thoughts?

I think this is fine as is, but maybe worth the other idea.

review: Approve

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-04-21:

Yes, in should be supported. I think sanitizing to dict at the db layer is probably the best idea, but there is going to be discussion at the summit about dicts vs objects, so I just worked around it for now.

Vish

On Apr 20, 2011, at 5:01 PM, termie wrote:

> Review: Approve
> I'd almost argue that we should support 'in' (and/or just return the dict version instead). Thoughts?
>
> I think this is fine as is, but maybe worth the other idea.
> --
> https://code.launchpad.net/~vishvananda/nova/lp767849/+merge/58597
> You are the owner of lp:~vishvananda/nova/lp767849.