Merge lp://staging/~vila/ubuntu-ci-services-itself/run-worker-conversion into lp://staging/ubuntu-ci-services-itself

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Evan
Approved revision: 349
Merged at revision: 368
Proposed branch: lp://staging/~vila/ubuntu-ci-services-itself/run-worker-conversion
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 510 lines (+121/-226)
6 files modified
branch-source-builder/bsbuilder/run_worker.py (+30/-51)
ci-utils/ci_utils/amqp_worker.py (+7/-4)
ci-utils/ci_utils/tests/test_amqp_worker.py (+8/-5)
image-builder/imagebuilder/run_worker.py (+15/-84)
run-tests (+1/-1)
test_runner/tstrun/run_worker.py (+60/-81)
To merge this branch: bzr merge lp://staging/~vila/ubuntu-ci-services-itself/run-worker-conversion
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210549@code.staging.launchpad.net

Commit message

Convert the run-workers over to the new common run-worker helper

Description of the change

Just a trivial fix on top of Andy's excellent work, only tests were impacted.

https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/run-worker-conversion/+merge/210078

Diff against target: 453 lines (+112/-220) 4 files modified

Can't argue against removing 100 lines ;)

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:349
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/391/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/391/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

I'm not having any luck with package builds today. But I have had a ticket get all the way through the image builder queue. Looks like this works just fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches