Ubuntu CI Services

Merge lp://staging/~vila/ubuntu-ci-services-itself/1292461-testbed-console-acquisition into lp://staging/ubuntu-ci-services-itself

  1. 1292461-testbed-console-acquisition
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 390
Merged at revision: 391
Proposed branch: lp://staging/~vila/ubuntu-ci-services-itself/1292461-testbed-console-acquisition
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 132 lines (+43/-20)
2 files modified
test_runner/tstrun/run_worker.py (+40/-18)
test_runner/tstrun/testbed.py (+3/-2)
To merge this branch: bzr merge lp://staging/~vila/ubuntu-ci-services-itself/1292461-testbed-console-acquisition
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211088@code.staging.launchpad.net

Commit message

Better error handling when setting up the test bed.

Description of the change

This refactors the message handling for the test runner to better isolate the
failures during the testbed setup.

More details in the bug comment.

While I was there I added some more progress reports so we get a better idea
on how the time is spent during the request handling.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:390
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/427/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/427/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

The handle_request method is starting to get a little complex, but lets deal with that post-phase0

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

> The handle_request method is starting to get a little complex, but lets deal
> with that post-phase0

Yeah and requires a bit too much care, full agreement.

On the other hand, the plan AIUI is to make it handle even more...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches