Ubuntu CI Services

Merge lp://staging/~vila/ubuntu-ci-services-itself/1289626-return-proper-code into lp://staging/ubuntu-ci-services-itself

1289626-return-proper-code
Merge into trunk

Proposed by Vincent Ladeuil on 2014-03-08

Status:

Merged

Approved by:

Chris Johnston on 2014-03-10

Approved revision:

345

Merged at revision:

349

Proposed branch:

lp://staging/~vila/ubuntu-ci-services-itself/1289626-return-proper-code

Merge into:

lp://staging/ubuntu-ci-services-itself

Diff against target:

28 lines (+4/-4)

2 files modified

juju-deployer/deploy.py (+1/-1)
test_runner/tstrun/testbed.py (+3/-3)

To merge this branch:

bzr merge lp://staging/~vila/ubuntu-ci-services-itself/1289626-return-proper-code

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Chris Johnston (community)		2014-03-08	Approve on 2014-03-10
PS Jenkins bot (community)	continuous-integration		Approve on 2014-03-10
Andy Doan (community)			Approve on 2014-03-10
Review via email: mp+210051@code.staging.launchpad.net

Commit message

Returns and propagate the proper exit code from the test runs.

Description of the change

Bah, TDD refugee mistake again, that one passed into the cracks.

This fixes the detection of test run failures by checking and propagating the proper return code.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-08:

FAILED: Continuous integration, rev:342
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/339/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/339/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Chris Johnston (cjohnston) wrote on 2014-03-08:

AssertionError: /home/ubuntu/jenkins/workspace/uci-engine-ci/uci-engine-autolanding/test_runner/tstrun/testbed.py:298:44: E127 continuation line over-indented for visual indent

I'm deploying now to test the code.

review: Needs Fixing

lp://staging/~vila/ubuntu-ci-services-itself/1289626-return-proper-code updated on 2014-03-08

343. By Vincent Ladeuil on 2014-03-08: Fix pep issue.

Revision history for this message

Vincent Ladeuil (vila) wrote on 2014-03-08:

> AssertionError: /home/ubuntu/jenkins/workspace/uci-engine-ci/uci-engine-
> autolanding/test_runner/tstrun/testbed.py:298:44: E127 continuation line over-
> indented for visual indent

Fixed, why didn't you posted that to the bug instead of a comment with no useful info ?

>
> I'm deploying now to test the code.

Thank you my dear.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-08:

PASSED: Continuous integration, rev:343
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/340/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/340/rebuild

review: Approve (continuous-integration)

Revision history for this message

Andy Doan (doanac) wrote on 2014-03-10:

I think this is ready for merging right?

review: Approve

lp://staging/~vila/ubuntu-ci-services-itself/1289626-return-proper-code updated on 2014-03-10

344. By Vincent Ladeuil on 2014-03-10: Merge trunk to avoid repeated payload uploads
345. By Vincent Ladeuil on 2014-03-10: Grr, previous reversion was wrong.