Ubuntu CI Services

Merge lp://staging/~vila/ubuntu-ci-services-itself/1285830-logging into lp://staging/ubuntu-ci-services-itself

  1. 1285830-logging
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 304
Merged at revision: 303
Proposed branch: lp://staging/~vila/ubuntu-ci-services-itself/1285830-logging
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 77 lines (+17/-7)
2 files modified
cli/ci_libs/file_handler.py (+7/-2)
cli/ubuntu-ci (+10/-5)
To merge this branch: bzr merge lp://staging/~vila/ubuntu-ci-services-itself/1285830-logging
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+209189@code.staging.launchpad.net

Commit message

Propagate log level from ubuntu-ci to the ci_libs/file_handler.py module.

Description of the change

See https://bugs.launchpad.net/ubuntu-ci-services-itself/+bug/1285830 for details, the log level wasn't propagated from the ubuntu-ci script to the file_handler module.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:303
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/282/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/282/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

+def set_log_level(log_ref):

Even though it's simple, this function could use documentation.

Otherwise +1

review: Approve
lp://staging/~vila/ubuntu-ci-services-itself/1285830-logging updated
304. By Vincent Ladeuil

Add docstring as per review advice.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches