Merge lp://staging/~vila/u1-test-utils/sudo-opt-in into lp://staging/u1-test-utils
Proposed by
Vincent Ladeuil
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Vincent Ladeuil | ||||
| Approved revision: | 95 | ||||
| Merged at revision: | 96 | ||||
| Proposed branch: | lp://staging/~vila/u1-test-utils/sudo-opt-in | ||||
| Merge into: | lp://staging/u1-test-utils | ||||
| Diff against target: |
102 lines (+17/-14) 2 files modified
setup_vm/tests/__init__.py (+11/-8) setup_vm/tests/test_setup_vm.py (+6/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~vila/u1-test-utils/sudo-opt-in | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
| Leo Arias (community) | code review | Approve | |
|
Review via email:
|
|||
Commit message
Tests requiring sudo should use an opt-in mechanism, nobody should blindly accept running them.
Description of the change
sudo access is hard to guess but it doesn't imply the user want to use it during tests.
This use ~/.setup_
To post a comment you must log in.
Revision history for this message
| Leo Arias (elopio) | # |
review:
Approve
(code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!