Merge lp://staging/~vila/ols-store-tests/better-reporting into lp://staging/ols-store-tests

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 33
Merged at revision: 31
Proposed branch: lp://staging/~vila/ols-store-tests/better-reporting
Merge into: lp://staging/ols-store-tests
Diff against target: 85 lines (+18/-9)
4 files modified
olsstore/__init__.py (+12/-3)
olsstore/_upload.py (+2/-2)
olsstore/config.py (+1/-1)
olsstore/tests/tapes/olsstore.tests.test_upload.TestUpload.test_upload_works (+3/-3)
To merge this branch: bzr merge lp://staging/~vila/ols-store-tests/better-reporting
Reviewer Review Type Date Requested Status
Fabián Ezequiel Gallina (community) Approve
Review via email: mp+321268@code.staging.launchpad.net

Commit message

Improve reporting on download errors and increase wait for upload scans.

Description of the change

This improves the reporting when downloading from updown with the url received from cpi (instead of failing later on with a SHAMismatchError which is confusing).

This also increases waiting for upload to succeed to avoid spurious failures with 'Package scan took too long'.

To post a comment you must log in.
Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches