Merge lp://staging/~vicamo/qtubuntu-sensors/reimplement-haptics-backend into lp://staging/qtubuntu-sensors

Proposed by You-Sheng Yang
Status: Merged
Merged at revision: 93
Proposed branch: lp://staging/~vicamo/qtubuntu-sensors/reimplement-haptics-backend
Merge into: lp://staging/qtubuntu-sensors
Diff against target: 248 lines (+93/-46)
3 files modified
plugins/feedback/CMakeLists.txt (+3/-5)
plugins/feedback/core_feedback.cpp (+84/-38)
plugins/feedback/core_feedback.h (+6/-3)
To merge this branch: bzr merge lp://staging/~vicamo/qtubuntu-sensors/reimplement-haptics-backend
Reviewer Review Type Date Requested Status
Thomas Voß Pending
Review via email: mp+300839@code.staging.launchpad.net

Commit message

This change rewrites QtFeedbackHapticsEffect backend for ubuntu.

The original implementation is to call APIs in libubuntu-platform-api, which then issue D-Bus calls to usensord. However, it seems in some cases instantiating a D-Bus call in such Qt module may result in segmentation fault. This change rewrites QtFeedbackHapticsEffect backend with QtDBus directly and works around this issue.

This change also tries to conform to QtFeedbackHaptics features definitions. Duration/period is now correctly supported, although this doesn't mean much because usensord does not support variable vibration intensity. It also provides a chance to stop a periodical vibration. The enable/state properties are now correctly set and returned.

Description of the change

This change rewrites QtFeedbackHapticsEffect backend for ubuntu.

The original implementation is to call APIs in libubuntu-platform-api, which then issue D-Bus calls to usensord. However, it seems in some cases instantiating a D-Bus call in such Qt module may result in segmentation fault. This change rewrites QtFeedbackHapticsEffect backend with QtDBus directly and works around this issue.

This change also tries to conform to QtFeedbackHaptics features definitions. Duration/period is now correctly supported, although this doesn't mean much because usensord does not support variable vibration intensity. It also provides a chance to stop a periodical vibration. The enable/state properties are now correctly set and returned.

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches