Ubuntu Terminal App

Merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

  1. uitk13-deprecation
  2. Merge into reboot
Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 183
Merged at revision: 195
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation
Merge into: lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 361 lines (+82/-130)
9 files modified
src/app/qml/CircularTransparentButton.qml (+1/-1)
src/app/qml/ColorSchemePage.qml (+30/-24)
src/app/qml/ExpandableButton.qml (+1/-1)
src/app/qml/KeyboardRows/ExpandableKeyboardButton.qml (+1/-1)
src/app/qml/KeyboardRows/KeyboardButton.qml (+1/-1)
src/app/qml/LayoutsPage.qml (+24/-17)
src/app/qml/SettingsPage.qml (+10/-7)
src/app/qml/TabsPage.qml (+13/-77)
src/app/qml/TerminalPage.qml (+1/-1)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/uitk13-deprecation
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Ubuntu Terminal Developers Pending
Review via email: mp+287990@code.staging.launchpad.net

Commit message

* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, instead of the QtQuick Text component
* Minor text margins fix in TabsPage

Description of the change

* Use UITK PageHeader, instead of the now deprecated "Page.head" property
* Use ScrollView where appropriate
* Use UITK Label, instead of the QtQuick Text component
* Minor text margins fix in TabsPage

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:183
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/51/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/799/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/51/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan McIntire (mcintire-evan) wrote :

All looks good to me, as I said before, I sadly can't test it, but from a lookover of the changes it all seems awesome :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches