Ubuntu Terminal App

Merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

  1. layouts-q-argument
  2. Merge into reboot
Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 158
Merged at revision: 162
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument
Merge into: lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 45 lines (+21/-2)
1 file modified
src/app/main.cpp (+21/-2)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument
Reviewer Review Type Date Requested Status
Evan McIntire Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+283786@code.staging.launchpad.net

Commit message

Fixed layouts not found when terminal-app is launched with '-q' argument

Description of the change

Fixed layouts not found when terminal-app is launched with '-q' argument

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:156
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/168/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/452/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/168/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Bernabei (faenil) wrote :

small comment

lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument updated
157. By Stefano Verzegnassi

added debug output as per MP review

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Done!

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:157
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/169/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/453/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/169/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Bernabei (faenil) wrote :

another comment :)

lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/layouts-q-argument updated
158. By Stefano Verzegnassi

Added output in case the default layouts folder doesn't exist, or no default layout has been found

Revision history for this message
Andrea Bernabei (faenil) wrote :

lgtm! thanks :)

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:158
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/170/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/454/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/170/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan McIntire (mcintire-evan) wrote :

Works well, code all looks good to me - Thanks for the change!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches