Merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588 into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 193
Merged at revision: 194
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588
Merge into: lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 90 lines (+17/-6)
3 files modified
src/app/qml/TerminalComponent.qml (+4/-0)
src/plugin/qmltermwidget/lib/TerminalDisplay.cpp (+3/-2)
src/plugin/qmltermwidget/lib/TerminalDisplay.h (+10/-4)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/fix-1488588
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Ubuntu Terminal Developers Pending
Review via email: mp+290031@code.staging.launchpad.net

Commit message

* Expose drag mode settings to QML
* Disabled drag support in ubuntu-terminal-app in order to workaround the missing support in Mir

Description of the change

* Expose drag mode settings to QML
* Disabled drag support in ubuntu-terminal-app in order to workaround the missing support in Mir

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Evan McIntire (mcintire-evan) wrote :

As with the other changes, looks good, but I can't test :( Thanks for the work - hopefully someone can test these and get them in before I get back from vacation

193. By Stefano Verzegnassi

updated DragMode enumerators name

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches