Merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/add-thumbnails-tabspage into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Proposed by
Stefano Verzegnassi
| Status: | Merged |
|---|---|
| Merge reported by: | Filippo Scognamiglio |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/add-thumbnails-tabspage |
| Merge into: | lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot |
| Diff against target: |
38 lines (+21/-4) 1 file modified
src/app/qml/TabsPage.qml (+21/-4) |
| To merge this branch: | bzr merge lp://staging/~verzegnassi-stefano/ubuntu-terminal-app/add-thumbnails-tabspage |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Filippo Scognamiglio | Approve | ||
|
Review via email:
|
|||
Commit message
Added thumbnails in Tabs page
Description of the change
Added thumbnails in Tabs page
Since the terminal widget is a QQuickItem, we can grab a thumbnail just using a shader. The pointer to QQuickItem is provided by TabsModel.
Just a note: this has been tested on desktop and on a Nexus 5. Please check if sizing is correct on Nexus 4 (and/or other devices w/ same resolution).
To post a comment you must log in.
Revision history for this message
| Filippo Scognamiglio (flscogna) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
