Ubuntu Document Viewer App

Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page into lp://staging/ubuntu-docviewer-app

uitk13-lok-page
Merge into lo-viewer

Proposed by Stefano Verzegnassi on 2016-03-24

Status:	Merged
Approved by:	Roman Shchekin on 2016-03-31
Approved revision:	321
Merged at revision:	326
Proposed branch:	lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page
Merge into:	lp://staging/ubuntu-docviewer-app
Diff against target:	548 lines (+207/-204) 4 files modified src/app/qml/common/ViewerPage.qml (+32/-3) src/app/qml/loView/KeybHelper.js (+23/-47) src/app/qml/loView/LOViewDefaultHeader.qml (+41/-55) src/app/qml/loView/LOViewPage.qml (+111/-99)
To merge this branch:	bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jenkins Bot	continuous-integration		Approve on 2016-03-30
Roman Shchekin		2016-03-24	Needs Information on 2016-03-30
Review via email: mp+290048@code.staging.launchpad.net

Commit message

* WORKAROUND: make the lok-viewer header static (avoid unpredictable binding)
* Use new PageHeader and ScrollView components
* UI: Show an empty header when loading LibreOffice

Description of the change

* WORKAROUND: make the lok-viewer header static (avoid unpredictable binding)
* Use new PageHeader and ScrollView components
* UI: Show an empty header when loading LibreOffice

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-03-24:

PASSED: Continuous integration, rev:320
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/261/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/811/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/261/rebuild

review: Approve (continuous-integration)

Revision history for this message

Roman Shchekin (mrqtros) wrote on 2016-03-30:

See inline comments!

review: Needs Information

Revision history for this message

Stefano Verzegnassi (verzegnassi-stefano) wrote on 2016-03-30:

> Haha, are you enjoyed deleting this code? ;)
Ahah, you can be sure of it! :)

> Why did you switch it [PageHeader.flickable] off? Just for information.
I was having trouble in setting the anchors for the content of the ViewerPage[1], and the LibreOffice Viewer had strange bindings that were causing a continuous flickering and reloading of the document content, every time the header was changing its status (i.e. visible/hidden).

I spent some time on it again (after you review), and now it seems to behave correctly. Pushing the new commit...

[1] We load LOViewPage asynchronously, but the loading logic is placed in a different file.

lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/uitk13-lok-page updated on 2016-03-30