Ubuntu Document Viewer App

Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector into lp://staging/ubuntu-docviewer-app

  1. spreadsheet-part-selector
  2. Merge into lo-viewer
Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 245
Merged at revision: 287
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector
Merge into: lp://staging/ubuntu-docviewer-app
Prerequisite: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/lok-qml-currentpart-moved
Diff against target: 415 lines (+162/-50)
7 files modified
po/com.ubuntu.docviewer.pot (+18/-7)
src/app/qml/loView/LOViewPage.qml (+39/-13)
src/app/qml/loView/SpreadsheetSelector.qml (+84/-0)
src/plugin/libreofficetoolkit-qml-plugin/lodocument.cpp (+8/-16)
src/plugin/libreofficetoolkit-qml-plugin/lodocument.h (+1/-6)
src/plugin/libreofficetoolkit-qml-plugin/loview.cpp (+2/-4)
src/plugin/libreofficetoolkit-qml-plugin/lozoom.cpp (+10/-4)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Needs Fixing
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Review via email: mp+282845@code.staging.launchpad.net

Commit message

LibreOffice viewer:
* Added a sheet selector
* Show an empty state when the current sheet has no content
* Fixed "currentPart" usage, partially broken after a recent commit in trunk

Description of the change

LibreOffice viewer:
* Added a sheet selector
* Show an empty state when the current sheet has no content
* Fixed "currentPart" usage, partially broken after a recent commit in trunk

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:243
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/172/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/456/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/172/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

This is excellent. Works really well.

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/65/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1479/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

It seems that Jenkins has run a build on revision 239, but it didn't update the review. Top-approving...

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:244
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/205/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/491/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/205/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Merging failed. More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/809/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1511/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/137/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1526/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/144/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1535/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/147/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1562/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Text conflict in po/com.ubuntu.docviewer.pot
1 conflicts encountered.

review: Needs Fixing
lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/spreadsheet-part-selector updated
245. By Stefano Verzegnassi

Merged trunk + updated .pot

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:245
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/992/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/539/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/992/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches