Ubuntu Document Viewer App

Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver into lp://staging/ubuntu-docviewer-app

pdf-presentation-disable-screen-saver
Merge into lo-viewer

Proposed by Stefano Verzegnassi on 2016-01-23

Status:	Merged
Approved by:	Alan Pope 🍺🐧🐱 🦄 on 2016-02-11
Approved revision:	282
Merged at revision:	298
Proposed branch:	lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver
Merge into:	lp://staging/ubuntu-docviewer-app
Diff against target:	37 lines (+8/-1) 2 files modified click/docviewer.apparmor (+2/-1) src/app/qml/ubuntu-docviewer-app.qml (+6/-0)
To merge this branch:	bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alan Pope 🍺🐧🐱 🦄 (community)		2016-01-23	Approve on 2016-02-11
Jenkins Bot	continuous-integration		Approve on 2016-02-07
Review via email: mp+283717@code.staging.launchpad.net

Commit message

[PdfPresentation] Disable screen saver during a presentation

Description of the change

[PdfPresentation] Disable screen saver during a presentation

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-01-23:

PASSED: Continuous integration, rev:278
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/167/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/449/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/167/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2016-01-28:

Tested this with a PDF in presentation mode on my bq running rc-proposed image and the screen still blanks.

review: Needs Fixing

Revision history for this message

Stefano Verzegnassi (verzegnassi-stefano) wrote on 2016-01-28:

I'm not really surprised by this.
When I tried to test it on my BQ (still rc-proposed) I've got exactly the opposite result. Even if I've set my phone to turn off the screen after a minute, it keeps staying on with any app.

I will give a further look tomorrow. In the meantime, thank you for the huge testing on my branches.

Revision history for this message

Stefano Verzegnassi (verzegnassi-stefano) wrote on 2016-02-06:

Ok, I found some time for working on this.
I forgot to commit the AppArmor permission for keeping the screen on (as always the problem exists between the chair and the keyboard :D)

However, it keeps on turning the screen off...

lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/pdf-presentation-disable-screen-saver updated on 2016-02-07

279. By Stefano Verzegnassi on 2016-02-07: Added keep-display-on policy
280. By Stefano Verzegnassi on 2016-02-07: Re-enable screen saver when the app is not focused
281. By Stefano Verzegnassi on 2016-02-07: Handle screen saver from the main qml file
282. By Stefano Verzegnassi on 2016-02-07: sync trunk