Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check into lp://staging/ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 268
Merged at revision: 277
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 51 lines (+27/-1)
3 files modified
click/disable-lo-features.sh (+3/-0)
click/disable-spell-check.xcd (+23/-0)
cmake/modules/Click.cmake (+1/-1)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/lo-disable-spell-check
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+282875@code.staging.launchpad.net

Commit message

Disable spell checking in LibreOffice:

* We don't need it since we don't provide any editing feature
* Our minimal build of LibreOffice doesn't have a full languages support
* In future we'll add a full-screen mode for .pptx/.ppt/.odp documents. Those red lines below the text are just terrible.

Description of the change

Disable spell checking in LibreOffice:

* We don't need it since we don't provide any editing feature
* Our minimal build of LibreOffice doesn't have a full languages support
* In future we'll add a full-screen mode for .pptx/.ppt/.odp documents. Those red lines below the text are just terrible.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches