Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-dispatcher-missing into lp://staging/ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 226
Merged at revision: 225
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-dispatcher-missing
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 22 lines (+1/-3)
2 files modified
click/manifest.json.in (+1/-1)
data/CMakeLists.txt (+0/-2)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-dispatcher-missing
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+279565@code.staging.launchpad.net

Commit message

Fixed url-dispatcher missing in the click package

Description of the change

Fixed url-dispatcher missing in the click package

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

That fixed the click-review error, nice one!

Now executing: click-review ./com.ubuntu.docviewer_2.0.latest_armhf.click
Errors
------
 - security:redflag_fields:docviewer.apparmor
 found redflagged fields (needs human review): read_path, write_path
./com.ubuntu.docviewer_2.0.latest_armhf.click: FAIL
Successfully built package in './com.ubuntu.docviewer_2.0.latest_armhf.click'.

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/20/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1356/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches