Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-deletion-from-external-storage into lp://staging/ubuntu-docviewer-app
| Status: | Merged |
|---|---|
| Approved by: | Roman Shchekin |
| Approved revision: | 242 |
| Merged at revision: | 242 |
| Proposed branch: | lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-deletion-from-external-storage |
| Merge into: | lp://staging/ubuntu-docviewer-app |
| Diff against target: |
13 lines (+2/-1) 1 file modified
click/docviewer.apparmor (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-deletion-from-external-storage |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Roman Shchekin | Approve | ||
| Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 | Pending | ||
|
Review via email:
|
|||
Commit message
Updated AppArmor template. It fixes the deletion of a document stored on a SD card.
Description of the change
Updated AppArmor template.
It fixes the deletion of a document stored on a SD card (which currently drops a DENIAL).
This would give us write permissions to the Documents folder in any external storage. Similar rights are already used by gallery-app and camera-app for similar reasons, through the 'picture_files' policy[1].
From the DocViewer perspective, this represents a move from an hypothetical 'document_
@Alan: I'm expressly asking you as reviewer for the reason above, since we may need a authorization from the security team (this would probably be the first case of confined core app using a less restrictive policy).
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | # |
PASSED: Continuous integration, rev:242
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/