Ubuntu Document Viewer App

Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 into lp://staging/ubuntu-docviewer-app

fix-1544149
Merge into lo-viewer

Proposed by Stefano Verzegnassi on 2016-02-10

Status:

Merged

Approved by:

Alan Pope 🍺🐧🐱 🦄 on 2016-02-12

Approved revision:

299

Merged at revision:

300

Proposed branch:

lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149

Merge into:

lp://staging/ubuntu-docviewer-app

Diff against target:

138 lines (+34/-21)

3 files modified

src/app/qml/common/ContentHubProxy.qml (+10/-9)
src/app/qml/documentPage/DocumentListView.qml (+1/-1)
src/app/qml/documentPage/DocumentPagePickModeHeader.qml (+23/-11)

To merge this branch:

bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alan Pope 🍺🐧🐱 🦄 (community)		2016-02-10	Approve on 2016-02-12
Jenkins Bot	continuous-integration		Approve on 2016-02-12
Review via email: mp+285641@code.staging.launchpad.net

Commit message

Fixed ContentTransferHint being visible during an export

Description of the change

Fixed ContentTransferHint being visible during an export

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-02-11:

PASSED: Continuous integration, rev:297
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1016/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/568/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1016/rebuild

review: Approve (continuous-integration)

Revision history for this message

Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote on 2016-02-11:

PASSED: Continuous integration, rev:297
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1018/
Executed test runs:
None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/570/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1018/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alan Pope 🍺🐧🐱 🦄 (popey) wrote on 2016-02-12:

Tested this on OTA-9. It brings up the document selector, and I can select a document to transfer. However when I then press the tick in the header, nothing happens. I get a vibrate so it did notice I pressed the tick, but it never transfers the file. The document selector still works, I can select and unselect documents, but I can never transfer them.

review: Needs Fixing

lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1544149 updated on 2016-02-12

298. By Stefano Verzegnassi on 2016-02-12: Fixed DocumentPagePickModeHeader:
* Use UCListItem 1.2+ APIs
* Use content-hub properly
299. By Stefano Verzegnassi on 2016-02-12: Restore the browse mode when the content transfer is completed or aborted