Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112 into lp://staging/ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Roman Shchekin
Approved revision: 242
Merged at revision: 245
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 84 lines (+41/-33)
1 file modified
src/app/qml/common/DetailsPage.qml (+41/-33)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523112
Reviewer Review Type Date Requested Status
Roman Shchekin Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+281364@code.staging.launchpad.net

Commit message

Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.

Description of the change

Added Flickable in DetailsPage. Content can be scrolled when bigger than the page.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Roman Shchekin (mrqtros) wrote :

The using of ListView can be better solution, but for now it is ok.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches