Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523106 into lp://staging/ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Stefano Verzegnassi
Approved revision: 246
Merged at revision: 253
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523106
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 203 lines (+50/-20)
5 files modified
po/com.ubuntu.docviewer.pot (+20/-16)
src/app/qml/common/DetailsPage.qml (+7/-1)
src/app/qml/common/SubtitledListItem.qml (+11/-3)
src/plugin/file-qml-plugin/docviewerutils.cpp (+10/-0)
src/plugin/file-qml-plugin/docviewerutils.h (+2/-0)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1523106
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+281375@code.staging.launchpad.net

Commit message

[DetailsPage] Split file name and file path into two separate fields. Allow multiline subtext.

Description of the change

[DetailsPage] Split file name and file path into two separate fields. Allow multiline subtext.

Screenshot at: https://imgur.com/IEgfKOW

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Great improvement. Works well on the small screen devices.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches