Merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/disable-file-locking into lp://staging/ubuntu-docviewer-app

Proposed by Stefano Verzegnassi
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 195
Merged at revision: 196
Proposed branch: lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/disable-file-locking
Merge into: lp://staging/ubuntu-docviewer-app
Diff against target: 45 lines (+23/-1)
3 files modified
CMakeLists.txt (+1/-1)
click/disable-file-locking.sh (+11/-0)
click/disable-file-locking.xcd (+11/-0)
To merge this branch: bzr merge lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/disable-file-locking
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+277698@code.staging.launchpad.net

Commit message

Disable file locking in LibreOffice

Description of the change

Disable file locking in LibreOffice

*** HOW TO TEST ***
1) Using the old testing release of DocViewer (2.0 - beta), open a Document
2) Check with File Manager (unlock advanced features first, in order to enable 'show hidden files' option), that a '.~lock' file has been created.
3) Close DocViewer and remove that file.
4) Build DocViewer from this branch and install it on device.
5) Open the same document again.
6) Repeat step 2. Ensure there's no '.~lock' file this time.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Works as expected! Thanks!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-autolanding/1/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/388/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches