Unity Reddit Scope

Merge lp://staging/~verterok/unity-scope-reddit/reddit-logging into lp://staging/unity-scope-reddit

  1. reddit-logging
  2. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Approved by: David Callé
Approved revision: 5
Merged at revision: 4
Proposed branch: lp://staging/~verterok/unity-scope-reddit/reddit-logging
Merge into: lp://staging/unity-scope-reddit
Diff against target: 103 lines (+22/-18)
2 files modified
src/unity_reddit_daemon.py (+21/-17)
tests/test_reddit.py (+1/-1)
To merge this branch: bzr merge lp://staging/~verterok/unity-scope-reddit/reddit-logging
Reviewer Review Type Date Requested Status
David Callé (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+187385@code.staging.launchpad.net

Commit message

Add basic logging (replace print with logging)

Description of the change

Add basic logging (replace print with logging)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:4
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/7/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-reddit-ci/7/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~verterok/unity-scope-reddit/reddit-logging updated
5. By Guillermo Gonzalez

fix test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-reddit-saucy-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-reddit-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Callé (davidc3) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches