Merge lp://staging/~verterok/ubuntuone-storage-protocol/fix-validators-python_cpp into lp://staging/ubuntuone-storage-protocol

Proposed by Guillermo Gonzalez
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 149
Merged at revision: 146
Proposed branch: lp://staging/~verterok/ubuntuone-storage-protocol/fix-validators-python_cpp
Merge into: lp://staging/ubuntuone-storage-protocol
Diff against target: 81 lines (+18/-5)
3 files modified
run-tests (+4/-1)
tests/test_putcontent.py (+7/-3)
ubuntuone/storageprotocol/validators.py (+7/-1)
To merge this branch: bzr merge lp://staging/~verterok/ubuntuone-storage-protocol/fix-validators-python_cpp
Reviewer Review Type Date Requested Status
Facundo Batista (community) Approve
dobey (community) Approve
Review via email: mp+102948@code.staging.launchpad.net

Commit message

Add support for protobuf cpp python extension, also change run-tests to run the tests with both implementations.

Description of the change

Add support for protobuf cpp python extension, also change run-tests to run the tests with both implementations.

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Can you please file a bug about the problem this is fixing, and link it to this branch with "bzr commit --unchanged --fixes=lp:BUGNO" afterward?

review: Needs Information
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi Rodney,

This isn't fixing any bug.

The idea is to start using the protobuf cpp extension (availbale in protobuf 2.4.1), this branch just fix a method in order to work with both, cpp extension and pure python, versions.

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Facundo Batista (facundo) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches