Ubuntu One Client

Merge lp://staging/~verterok/ubuntuone-client/fix-646112-stable-1-4 into lp://staging/ubuntuone-client/stable-1-4

  1. fix-646112-stable-1-4
  2. Merge into stable-1-4
Proposed by Guillermo Gonzalez
Status: Merged
Approved by: dobey
Approved revision: 722
Merged at revision: 727
Proposed branch: lp://staging/~verterok/ubuntuone-client/fix-646112-stable-1-4
Merge into: lp://staging/ubuntuone-client/stable-1-4
Diff against target: 136 lines (+94/-0)
2 files modified
tests/syncdaemon/test_vm.py (+77/-0)
ubuntuone/syncdaemon/volume_manager.py (+17/-0)
To merge this branch: bzr merge lp://staging/~verterok/ubuntuone-client/fix-646112-stable-1-4
Reviewer Review Type Date Requested Status
dobey (community) Abstain
Lucio Torre (community) Approve
Facundo Batista (community) Approve
Review via email: mp+36560@code.staging.launchpad.net

Commit message

Send VM_SHARE_CREATED event when an accepted share is detected during server rescan/list volumes.

Description of the change

This branch fixes VM to correctly handle accepted shares on server/volumes rescan and also improve logging of Volume kinds

To post a comment you must log in.
Revision history for this message
Facundo Batista (facundo) wrote :

Like it!

review: Approve
Revision history for this message
dobey (dobey) wrote :

It looks like you have added code to this, which wasn't included in the same change to trunk. Is it necessary here? Why wasn't it added to trunk also?

review: Needs Information
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

The code was added because a reviewer noticing the problem, a branch to include this in trunk is proposed: https://code.edge.launchpad.net/~verterok/ubuntuone-client/fix-646112-dbus-signal/+merge/36795

Revision history for this message
Facundo Batista (facundo) wrote :

Re-reviewed, it's ok.

review: Approve
Revision history for this message
Lucio Torre (lucio.torre) wrote :

works! and notifies!

review: Approve
Revision history for this message
dobey (dobey) :
review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches