Merge lp://staging/~verterok/tanuki-continuous-deployer/stop-the-line into lp://staging/tanuki-continuous-deployer

Proposed by Guillermo Gonzalez
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 23
Merged at revision: 19
Proposed branch: lp://staging/~verterok/tanuki-continuous-deployer/stop-the-line
Merge into: lp://staging/tanuki-continuous-deployer
Diff against target: 131 lines (+60/-12)
2 files modified
cd.py (+27/-9)
manage.py (+33/-3)
To merge this branch: bzr merge lp://staging/~verterok/tanuki-continuous-deployer/stop-the-line
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+270183@code.staging.launchpad.net

Commit message

Add stop|start-deploys command to manage.py and make cd.py bail out when line is stopped (also added args to override and be able to debug deploys)

Description of the change

Add stop|start-deploys command to manage.py and make cd.py bail out when line is stopped (also added args to override and be able to debug deploys)

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Guillermo,

Thanks for proposing an alternative for safely freezing staging.

In order to make the situation clear to everyone, including people not accessing wendigo frequently, I suggest we push warnings to ELK on skipped deployments (explaining it was skipped because someone has stopped-the-line).

Let me know what you think ...

review: Needs Information
23. By Guillermo Gonzalez

log skipped deploy as warning, and add extra info for logstash

Revision history for this message
Celso Providelo (cprov) wrote :

SUper!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches