loggerhead

Merge lp://staging/~verterok/loggerhead/logging into lp://staging/loggerhead

logging
Merge into trunk-rich

Proposed by Guillermo Gonzalez on 2008-09-10

Status:

Superseded

Proposed branch:

lp://staging/~verterok/loggerhead/logging

Merge into:

lp://staging/loggerhead

To merge this branch:

bzr merge lp://staging/~verterok/loggerhead/logging

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Michael Hudson-Doyle	2008-09-10	Approve on 2008-09-29
Martin Albisetti	2008-09-10	Pending
Review via email: mp+995@code.staging.launchpad.net

This proposal supersedes a proposal from 2008-09-09.

This proposal has been superseded by a proposal from 2008-09-29.

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2008-09-24:

I made some clean-up type changes in https://code.edge.launchpad.net/~mwhudson/loggerhead/logging.

I'm not sure that displaying "[(<class 'bzrlib.errors.NoSuchId'>, NoSuchId(), <traceback object at 0x1586680>)]" to the user really helps them very much. Can you maybe make this end of things a little nicer?

Other than that, it looks good!

Revision history for this message

Guillermo Gonzalez (verterok) wrote on 2008-09-25:

Hi Michael,
Thanks for the review (and the cleanup :-)
Fully agree, showing <class 'bzrlib.errors.NoSuchId'>... to the user isn't ok.
it' was just an example :-p
I'll improve the template and controller, and resubmit.

Thanks,

lp://staging/~verterok/loggerhead/logging updated on 2008-09-29

226. By Guillermo Gonzalez on 2008-09-26: merge with mwhudson logging branch
227. By Guillermo Gonzalez on 2008-09-27: * add formatting to the exception in error_ui (don't show the exc_info raw attributes)
228. By Guillermo Gonzalez on 2008-09-27: * History.fix_revid raise bzrlib.errors.NoSuchRevision, instead of KeyError
229. By Guillermo Gonzalez on 2008-09-29: * improve L&F of the error template (integrate it into the main template)
230. By Guillermo Gonzalez on 2008-09-29: * merge with trunk