lalita

Merge lp://staging/~verterok/lalita/the-twisted-way-to-reconnect into lp://staging/lalita

  1. the-twisted-way-to-reconnect
  2. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Merge reported by: Facundo Batista
Merged at revision: not available
Proposed branch: lp://staging/~verterok/lalita/the-twisted-way-to-reconnect
Merge into: lp://staging/lalita
Diff against target: 102 lines (+21/-8)
4 files modified
lalita/core/dispatcher.py (+2/-2)
lalita/core/tests/test_dispatcher.py (+12/-1)
lalita/core/tests/test_events.py (+1/-1)
lalita/ircbot.py (+6/-4)
To merge this branch: bzr merge lp://staging/~verterok/lalita/the-twisted-way-to-reconnect
Reviewer Review Type Date Requested Status
Facundo Batista Approve
Review via email: mp+23969@code.staging.launchpad.net

Commit message

use ReconnectingClientFactory instead of ClientFactory and fix missing command string formatting to use translations.

Description of the change

This branch change the way the bot reconnects, now it use the ReconnectingClientFactory from twisted instead of using custom code.
Also, fix missing command string formatting to use translations.

To post a comment you must log in.
Revision history for this message
Facundo Batista (facundo) wrote :

Nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches