Juju Charms Collection
storage package

Merge lp://staging/~verterok/charms/precise/storage/wait-a-bit-longer-if-needed into lp://staging/charms/storage

  1. Precise Pangolin (12.04)
  2. wait-a-bit-longer-if-needed
  3. Merge into trunk
Proposed by Guillermo Gonzalez
Status: Merged
Merged at revision: 41
Proposed branch: lp://staging/~verterok/charms/precise/storage/wait-a-bit-longer-if-needed
Merge into: lp://staging/charms/storage
Diff against target: 205 lines (+32/-20)
4 files modified
config.yaml (+5/-0)
hooks/common_util.py (+7/-5)
hooks/storage-provider.d/block-storage-broker/block-storage-relation-changed (+2/-1)
hooks/test_common_util.py (+18/-14)
To merge this branch: bzr merge lp://staging/~verterok/charms/precise/storage/wait-a-bit-longer-if-needed
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Cory Johns (community) Approve
Review via email: mp+263016@code.staging.launchpad.net

Commit message

Add a device_timeout config, default to current 50sec. value to allow configuring how long it waits for a device. Also fix a couple of tests that failed when comparing strings with a \n at the end

Description of the change

Add a device_timeout config, default to current 50sec. value to allow configuring how long it waits for a device. Also fix a couple of tests that failed when comparing strings with a \n at the end

To post a comment you must log in.
Revision history for this message
Cory Johns (johnsca) wrote :

This seems entirely reasonable to me, and both the existing and new test cases pass.

+1

review: Approve
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM. Thank you for taking the time to submit this fix for the charm store. We appreciate your work. I've merged this branch and it should be available in the charm store after the next ingestion.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: