Canonical SSO provider

Merge lp://staging/~verterok/canonical-identity-provider/focal into lp://staging/~ubuntuone-pqm-team/canonical-identity-provider/charm-focal

  1. focal
  2. Merge into charm-focal
Proposed by Guillermo Gonzalez
Status: Needs review
Proposed branch: lp://staging/~verterok/canonical-identity-provider/focal
Merge into: lp://staging/~ubuntuone-pqm-team/canonical-identity-provider/charm-focal
Diff against target: 12 lines (+2/-0)
1 file modified
playbook.yaml (+2/-0)
To merge this branch: bzr merge lp://staging/~verterok/canonical-identity-provider/focal
Reviewer Review Type Date Requested Status
Odysseus Kaziolas Approve
Maximiliano Bertacchini Approve
Review via email: mp+446330@code.staging.launchpad.net

Commit message

Workaround for payload role download to allow downloading public assets by setting a fake token if no swift credentials/auth_url are set

This simplify local deployments by not requiring the swift credentials to generate an auth-token that is not really needed.

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) :
review: Approve
Reply
Revision history for this message
Odysseus Kaziolas (odysseus-k) wrote :

LGTM, thank you.

Just a nitpick; the commit message should read *This simplifies[...]

review: Approve
Reply

Unmerged revisions

128. By Guillermo Gonzalez

workaround payload role download and allow downloading public assets by setting a fake token if no swift credentials/auth_url are set

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches