XPathSelect

Merge lp://staging/~veebers/xpathselect/fix_for_colons_in_node_name_1281688 into lp://staging/xpathselect

  1. fix_for_colons_in_node_name_1281688
  2. Merge into trunk
Proposed by Christopher Lee
Status: Merged
Approved by: Thomi Richards
Approved revision: 45
Merged at revision: 42
Proposed branch: lp://staging/~veebers/xpathselect/fix_for_colons_in_node_name_1281688
Merge into: lp://staging/xpathselect
Diff against target: 33 lines (+5/-2)
2 files modified
lib/parser.h (+1/-1)
test/test_parser.cpp (+4/-1)
To merge this branch: bzr merge lp://staging/~veebers/xpathselect/fix_for_colons_in_node_name_1281688
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+207289@code.staging.launchpad.net

Commit message

Node names can now contain colons (so names like Internal::MainWindow work). Tests added.

Description of the change

Node names can now contain colons (so names like Internal::MainWindow work). Tests added.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/xpathselect-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-trusty-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-trusty-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/xpathselect-ci/7/rebuild

review: Approve (continuous-integration)
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches