Merge lp://staging/~veebers/unity/fix_draging_last_position_out_of_launcher into lp://staging/unity

Proposed by Christopher Lee
Status: Merged
Approved by: Sebastien Bacher
Approved revision: no longer in the source branch.
Merged at revision: 2407
Proposed branch: lp://staging/~veebers/unity/fix_draging_last_position_out_of_launcher
Merge into: lp://staging/unity
Diff against target: 227 lines (+164/-2)
3 files modified
launcher/Launcher.cpp (+30/-2)
tests/autopilot/unity/emulators/launcher.py (+78/-0)
tests/autopilot/unity/tests/test_launcher.py (+56/-0)
To merge this branch: bzr merge lp://staging/~veebers/unity/fix_draging_last_position_out_of_launcher
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
Review via email: mp+109562@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-06-05.

Commit message

Launcher: Fix dragging to the last position when out of the launcher

Description of the change

Launcher: Fix dragging to the last position when out of the launcher

Without this patch there is the following bug:
 * Have a launcher with free space under the workspace switcher
 * Start dragging a tile from the launcher
 * Move it outside (to the right) of the launcher
 * See how a horizontal bar shows where the icon will land once you release the mouse button
 * Move the mouse down so the horizontal bar should go just before the worspace switcher
 * See that it doesn't go there, it keeps itself one icon before that

With this patch this behaviour is fixed

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

that's fixing bug #971421 right?

Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Yep, it is

Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Sorry if someone was working on this already :D

Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

no, I don't think anyone was working on it, I'm just trying to make sure bugs are connected to merge requests, that will also make SRUing the fix easier

Revision history for this message
Tim Penhey (thumper) wrote : Posted in a previous version of this proposal

I'm getting Chris to write an autopilot test for this :-)

Revision history for this message
Christopher Lee (veebers) wrote :

Resubmitted, now with autopilot tests.

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.