Merge lp://staging/~veebers/juju-ci-tools/introduce_statepool_tst into lp://staging/juju-ci-tools
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~veebers/juju-ci-tools/introduce_statepool_tst |
| Merge into: | lp://staging/juju-ci-tools |
| Diff against target: |
356 lines (+292/-6) 5 files modified
assess_statepool.py (+145/-0) jujupy/client.py (+3/-2) jujupy/tests/test_client.py (+5/-3) jujupy/tests/test_version_client.py (+1/-1) tests/test_assess_statepool.py (+138/-0) |
| To merge this branch: | bzr merge lp://staging/~veebers/juju-ci-tools/introduce_statepool_tst |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Add test that checks juju internals that the statepool has model states removed when required.
Description of the change
Add test that checks juju internals that the statepool has model states removed when required.
This is a test for Tims memory usage fix. In the past it was possible that a model would go away (destroyed or otherwise) but the controller would never release the state details it held for that model. This meant that memory usage grew overtime regardless of how many models where removed.
This test uses iptables to disrupt the agent on the deployed model until it is considered 'lost' by the controller (it then removes this disruption so that it can be cleaned up successfully). Then we check that the internal statepool report shows that it no longer has any reference to the removed models.
In 2.1 this fails (it lacks the fix) 2.2 passes (as it contains the fix).
Unmerged revisions
- 1965. By Christopher Lee
-
Fix command mixup
- 1964. By Christopher Lee
-
Safer iptables commands.
- 1963. By Christopher Lee
-
Add details on what the test is for.
- 1962. By Christopher Lee
-
Quick rename.
- 1961. By Christopher Lee
-
Tests for components.
- 1960. By Christopher Lee
-
Update existing tests to expect new flag.
- 1959. By Christopher Lee
-
Fix typo issue.
- 1958. By Christopher Lee
-
Fix oversights.
- 1957. By Christopher Lee
-
Initial iptables based attempt.
- 1956. By Christopher Lee
-
Merge parent.
Thank you. I have a suggestion for restoring iptables inline.