Merge lp://staging/~veebers/juju-ci-tools/adding_model_destory_test into lp://staging/juju-ci-tools

Proposed by Christopher Lee
Status: Needs review
Proposed branch: lp://staging/~veebers/juju-ci-tools/adding_model_destory_test
Merge into: lp://staging/juju-ci-tools
Diff against target: 266 lines (+257/-0)
2 files modified
assess_destroy_model.py (+122/-0)
tests/test_assess_destroy_model.py (+135/-0)
To merge this branch: bzr merge lp://staging/~veebers/juju-ci-tools/adding_model_destory_test
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+303215@code.staging.launchpad.net

Commit message

Description of the change

Add functional test for bug: https://bugs.launchpad.net/juju-core/+bug/1582021
This test was request by core devs in case of regression.

It does a couple of things against the grain of normal usage of jujupy, namely using the 'switch' command. This is due to the nature of the bug and test.

It also has a gross workaround where it uses a sleep around the creation and deletion of a model due to bug https://bugs.launchpad.net/juju-core/+bug/1613960. Perhaps there is a better way to do this?

Tests that deleting the in-focus model removes the current model and the ability to switch to a new model to set it.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Unmerged revisions

1561. By Christopher Lee

Actually use unit tests and with a fix.

1560. By Christopher Lee

Add gross workaround for bug (1613960)

1559. By Christopher Lee

Add reference to bug this test is to cover

1558. By Christopher Lee

Fix status command check

1557. By Christopher Lee

Fixed call to 'switch'.

1556. By Christopher Lee

Initial pass of simple test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches