lp://staging/gtk-vnc

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

687. By Guido Günther on 2017-02-14

Link against GIO_LIBS explicitly

to avoid

libtool: link: gcc -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -fdebug-prefix-map=/build/gtk-vnc-0.6.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
 -Wl,-z -Wl,now -o .libs/vncconnectiontest vncconnectiontest-vncconnectiontest.o ./.libs/libgvnc-1.0.so -lz -pthread
/usr/bin/ld: vncconnectiontest-vncconnectiontest.o: undefined reference to symbol 'g_io_stream_get_output_stream'
//usr/lib/x86_64-linux-gnu/libgio-2.0.so.0: error adding symbols: DSO missing from command line

Also make the use of *_CFLAGS and *_LIBS match.

686. By Daniel Berrange on 2017-02-09

Bump to 0.7.0 for new release

Signed-off-by: Daniel P. Berrange <email address hidden>

685. By Daniel Berrange on 2017-02-08

Clamp cursor hot-pixel to be within cursor region

Some broken VNC servers send hot-pixel outside bounds of the
cursor. We could disconnect and report an error, but it is
more user friendly to just clamp the hot pixel coords

https://bugzilla.gnome.org/show_bug.cgi?id=775394

Signed-off-by: Daniel P. Berrange <email address hidden>

684. By Eric R. Schulz <email address hidden> on 2017-02-08

Fix memory leaks

Call gnutls_deinit() after gnutls_bye().
Call g_free() in finalize().
Call g_free() in vnc_grab_sequence_free().

683. By Daniel Berrange on 2017-02-08

Fix some misc warnings & mem leak in test case

Signed-off-by: Daniel P. Berrange <email address hidden>

682. By Christophe Fergeau <email address hidden> on 2017-02-08

README: Update URL to home page

The old page no longer seems to exist in GNOME's wiki.

681. By Christophe Fergeau <email address hidden> on 2017-02-08

Add preconditions to VncDisplay public methods

This should catch invalid arguments being passed to these. This required
moving the VncDisplayPrivate *priv = display->priv; assignment as the
VNC_IS_DISPLAY(display) check is also a NULL check which we want to
happen before dereferencing it.

680. By Christophe Fergeau <email address hidden> on 2017-02-08

Avoid crash if attempt to connect to an invalid host or port

If vnc_display_open_host() is called with a NULL port or host,
vnc_connection_open_host_internal() will eventually crash.
This commits adds runtime checks to return early with
g_return_val_if_fail() when this happens rather than
crashing

 #0 0x00007ffff37de3d3 in __strchr_sse2 () at ../sysdeps/x86_64/strchr.S:32
 #1 0x00007ffff4661a17 in g_inet_socket_address_new_from_string (address=0x0, port=0)
     at ginetsocketaddress.c:416
 #2 0x00007ffff466b784 in g_network_address_parse_sockaddr (addr=addr@entry=0x969f50 [GNetworkAddress])
     at gnetworkaddress.c:245
 #3 0x00007ffff466ba94 in g_network_address_address_enumerator_next (enumerator=0x972ca0 [GNetworkAddressAddressEnumerator], cancellable=0x0, error=<optimized out>) at gnetworkaddress.c:919
 #4 0x00007ffff727130b in vnc_connection_open_host_internal (conn=0x99bbf0 [VncConnection])
     at vncconnection.c:5395
 #5 0x00007ffff7271523 in vnc_connection_coroutine (opaque=0x99bbf0) at vncconnection.c:5448
 #6 0x00007ffff7272e54 in coroutine_trampoline (cc=0x998080) at coroutine_ucontext.c:55
 #7 0x00007ffff7272b65 in continuation_trampoline (i0=10059904, i1=0) at continuation.c:43
 #8 0x00007ffff379dc00 in __start_context () at /lib64/libc.so.6
 #9 0x0000000000998448 in ()
 #10 0x0000000000000000 in ()

679. By Rico Tzschichholz on 2017-02-08

Add missing vala .deps files for gvnc & gvncpulse

https://bugzilla.gnome.org/show_bug.cgi?id=772322

Signed-off-by: Daniel P. Berrange <email address hidden>

678. By Daniel Berrange on 2017-02-07

Correctly validate color map range indexes

The color map index could wrap around to zero causing negative
array index accesses.

https://bugzilla.gnome.org/show_bug.cgi?id=778050

CVE-2017-5885

Signed-off-by: Daniel P. Berrange <email address hidden>