openerp-mexico-localization

Merge lp://staging/~vauxoo/openerp-mexico-localization/l10n_mx_purchase_payment_method_dev_luis into lp://staging/openerp-mexico-localization

l10n_mx_purchase_payment_method_dev_luis
Merge into trunk

Proposed by Luis Torres - http://www.vauxoo.com on 2012-09-07

Status:	Merged
Merged at revision:	202
Proposed branch:	lp://staging/~vauxoo/openerp-mexico-localization/l10n_mx_purchase_payment_method_dev_luis
Merge into:	lp://staging/openerp-mexico-localization
Diff against target:	176 lines (+156/-0) 4 files modified l10n_mx_purchase_payment_method/__init__.py (+27/-0) l10n_mx_purchase_payment_method/__openerp__.py (+39/-0) l10n_mx_purchase_payment_method/purchase.py (+41/-0) l10n_mx_purchase_payment_method/stock.py (+49/-0)
To merge this branch:	bzr merge lp://staging/~vauxoo/openerp-mexico-localization/l10n_mx_purchase_payment_method_dev_luis
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Luis Torres - http://www.vauxoo.com (community)		Needs Resubmitting on 2012-09-11
Moisés López - http://www.vauxoo.com	2012-09-07	Needs Fixing on 2012-09-11
Isaac López Zúñiga	2012-09-07	Pending
Review via email: mp+123364@code.staging.launchpad.net

Description of the change

Este modulo agrega a la funcion de crear facturas desde facturas de cliente y picking la funcion para escribir el pay_method_id y el acc_payment, que se introducieron en la orden de compra que genero esto...

Revision history for this message

Moisés López - http://www.vauxoo.com (moylop260) wrote on 2012-09-11:

Luis,
El archivo
l10n_mx_purchase_payment_method/account_invoice.py
Está fuera del contexto de esta propuesta de merge, está agregando referencias del picking a la invoice.
Y lo que dice, es que debería agregar pay_method_id y acc_payment

Se el archivo
l10n_mx_purchase_payment_method/stock_picking.py
En 2 archivos
l10n_mx_purchase_payment_method/stock.py
con la class stock_picking(osv.osv)
l10n_mx_purchase_payment_method/purchase.py
con la class purchase_order

review: Needs Fixing

Revision history for this message

Moisés López - http://www.vauxoo.com (moylop260) wrote on 2012-09-11:

Cuando obtengas el valores referenciados a otros modelos, valida que no venga vacio.
Por ejemplo:
acc_payment_id=purchase_order_id.acc_payment.id
Validar
acc_payment_id= purchase_order_id.acc_payment and purchase_order_id.acc_payment.id or False

review: Needs Fixing

lp://staging/~vauxoo/openerp-mexico-localization/l10n_mx_purchase_payment_method_dev_luis updated on 2012-09-11

179. By Luis Torres - http://www.vauxoo.com on 2012-09-11: [IMP]Delete account_invoice.py & separated stock_picking.py in stock.py & purchase.py
180. By Luis Torres - http://www.vauxoo.com on 2012-09-11: [IMP]Add validation for fields not empty

Revision history for this message

Luis Torres - http://www.vauxoo.com (luis-cleto-) wrote on 2012-09-11:

Se elimino el documento account_invoice y el doc stock_picking se dividio en 2 clases nuevas
Se agrego una validacion para que los campos que se van a escribir no sean vacios

review: Needs Resubmitting