Merge lp://staging/~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos into lp://staging/openerp-mexico-localization/7.0

Proposed by Juan Carlos Hernandez
Status: Merged
Merged at revision: 214
Proposed branch: lp://staging/~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos
Merge into: lp://staging/openerp-mexico-localization/7.0
Diff against target: 25 lines (+2/-2)
2 files modified
l10n_mx_payment_method/__openerp__.py (+1/-1)
l10n_mx_payment_method/partner_view.xml (+1/-1)
To merge this branch: bzr merge lp://staging/~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos
Reviewer Review Type Date Requested Status
Moisés López - http://www.vauxoo.com Approve
Juan Carlos Hernandez (community) Needs Resubmitting
Julio Serna-http://www.vauxoo.com Pending
Isaac López Zúñiga Pending
Review via email: mp+167172@code.staging.launchpad.net

Description of the change

se agrego dependencia

To post a comment you must log in.
Revision history for this message
Juan Carlos Hernandez (openerp1) wrote :

Moy
ya quedo bien la propuesta de merge

2013/6/3 Juan Carlos Hernandez Funes <email address hidden>

> Juan Carlos Hernandez Funes has proposed merging
> lp:~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos
> into lp:openerp-mexico-localization/7.0.
>
> Requested reviews:
> Isaac López Zúñiga - http://www.vauxoo.com (isaako34)
> Moisés López - http://www.vauxoo.com (moylop260)
> Vauxoo (vauxoo)
>
> For more details, see:
>
> https://code.launchpad.net/~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos/+merge/167172
>
> se agrego dependencia
> --
>
> https://code.launchpad.net/~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos/+merge/167172
> You proposed
> lp:~vauxoo/openerp-mexico-localization/7.0_l10n_mx_payment_method_dev_carlos
> for merging.
>
> === modified file 'l10n_mx_payment_method/__openerp__.py'
> --- l10n_mx_payment_method/__openerp__.py 2013-02-21 00:18:23 +0000
> +++ l10n_mx_payment_method/__openerp__.py 2013-06-03 22:32:28 +0000
> @@ -34,7 +34,7 @@
> """,
> "website" : "www.vauxoo.com",
> "license" : "AGPL-3",
> - "depends" : ["account",
> + "depends" : ["account", "base_vat",
> ],
> "init_xml" : [],
> "demo_xml" : [],
>
>
>

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Juan Carlos,
Ya quedó bien la propuesta, ahora sí analizándola, me doy cuenta del verdadero problema del tema técnico de la vista.

La vista <record model="ir.ui.view" id="view_partner_form_inh_xml22">
Hereda a la vista base_vat.view_partner_form"
Que esta a su vez, viene heredada de base.view_partner_form, la cual, esta última es la verdadera vista padre, la cual es la que se debería estar heredando desde este módulo.

Conclusión:
Dejar el __openerp__.py con depends ["account"] (solo sin "base_vat")
Cambiar la vista actual a la cual se está heredando <field name="inherit_id" ref="base_vat.view_partner_form"/>
ahora cambiar mejor a la vista padre <field name="inherit_id" ref="base.view_partner_form"/>

NOTA: No estoy seguro del nombre de la vista padre, pero la puedes ver en server/openerp/addons/base/

review: Needs Fixing
245. By Juan Carlos Hernandez

[IMP][l10n_mx_payment_method]change inherit view to base.view_partner_form and delete dependence base_vat

Revision history for this message
Juan Carlos Hernandez (openerp1) wrote :

cambia la herancia a vista padre a base.view_partner_form y se borro la dependencia base_vat

review: Needs Resubmitting
Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Aprobado!
Gracias!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.