Unity 8

Merge lp://staging/~vanvugt/unity8/fix-1497105 into lp://staging/unity8

  1. fix-1497105
  2. Merge into trunk
Proposed by Daniel van Vugt
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 2749
Merged at revision: 2763
Proposed branch: lp://staging/~vanvugt/unity8/fix-1497105
Merge into: lp://staging/unity8
Diff against target: 36 lines (+14/-5)
1 file modified
data/unity8.conf (+14/-5)
To merge this branch: bzr merge lp://staging/~vanvugt/unity8/fix-1497105
Reviewer Review Type Date Requested Status
Gerry Boland (community) code Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+314212@code.staging.launchpad.net

Commit message

Deprecate usage of Mir's input resampling, instead opting for:
  Shell: Raw native input events
  Apps: Qt's built-in touch compression input resampling algorithm,
         and other toolkits are expected to provide their own.

This fixes LP: #1497105 nicely, allowing apps to receive the full-speed
input stream (if they ask their toolkit to give it to them).

As an added bonus this also eliminates the 0-16.9ms (average 8.4ms) of
input lag that apps under Unity8 would experience. We do still have the
problem of output lag making everything still look laggy but I am
working to eliminate that soon in Mir 0.26.0.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2749
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2837/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3715
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2138
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2138
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3743
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3587/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3587/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3587/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3587/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3587/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3587
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3587/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2837/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

Tested on my laptop no issues found

Revision history for this message
Gerry Boland (gerboland) wrote :

looks ok

review: Approve (code)
Revision history for this message
Gerry Boland (gerboland) wrote :

Function-wise, my concern would be that unity8 will have more work to do as it has to deal with all the events, instead of a sampling. So need to test this well on touch-heavy platforms.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I know the shell will need to deal with the higher input frequency but:

(a) That's an unavoidable problem since clients need the option of receiving that raw input at high frequency; and

(b) The problem is confined to the shell only, and needs only be fixed in that one place if at all; and

(c) Testing on Unity8 desktop where USB mice generate 125Hz events seems to work nicely (and is a noticeable improvement); and

(d) Worst case is that all touch apps (including dash) are now more responsive at the expense of the switcher and notification pull-down. So I think that's a more sensible priority.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches