Merge lp://staging/~vanvugt/ubuntu-system-settings/fix-1569227 into lp://staging/ubuntu-system-settings
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Approved by: | Jonas G. Drange |
| Approved revision: | 1742 |
| Merged at revision: | 1743 |
| Proposed branch: | lp://staging/~vanvugt/ubuntu-system-settings/fix-1569227 |
| Merge into: | lp://staging/ubuntu-system-settings |
| Diff against target: |
154 lines (+21/-50) 3 files modified
plugins/mouse/Connected.qml (+18/-25) plugins/mouse/ItemTitle.qml (+1/-1) plugins/mouse/SectionHeader.qml (+2/-24) |
| To merge this branch: | bzr merge lp://staging/~vanvugt/ubuntu-system-settings/fix-1569227 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonas G. Drange (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix unlabelled sliders in Mouse & Touchpad (LP: #1569227)
The problem was that the labels existed but had been clipped to zero
height in ItemTitle.qml, so never appeared. However once you make them
appear they conflict visually with the things around them (also fixed
here).
Also:
* improved the title texts
* increased the visibility of the main Mouse and Touchpad titles
* removed the clumsy misplaced "Slow" and "Fast" labels
* added comments describing what needs fixing next (in SliderMenu
which is a different project) to replace the old Slow and Fast labels
System Settings needs A LOT of visual fixes so I had to restrain myself
and tried to keep this change mostly about just fixing LP: #1569227.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, thank you.